[PATCH v4 2/4] apply: do not read from the filesystem under --index
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 10, 2015, 22:36 UTC
- Message-ID
- <1423607771-27157-3-git-send-email-gitster@pobox.com>
- In-Reply-To
- <1423607771-27157-1-git-send-email-gitster@pobox.com>
We currently read the preimage to apply a patch from the index only when the --cached option is given. Do so also when the command is running under the --index option. With --index, the index entry and the working tree file for a path that is involved in a patch must be identical, so this should not affect the result, but by reading from the index, we will get the protection to avoid reading an unintended path beyond a symbolic link automatically.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin/apply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/apply.c b/builtin/apply.c index 8561236..21e45a0 100644 --- a/builtin/apply.c +++ b/builtin/apply.c @@ -3136,7 +3136,7 @@ static int load_patch_target(struct strbuf *buf, const char *name, unsigned expected_mode) { - if (cached) { + if (cached || check_index) { if (read_file_or_gitlink(ce, buf)) return error(_("read of %s failed"), name); } else if (name) {
-- 2.3.0-185-g073f588