git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug: Incorrect stripping of the [PATCH] prefix in git-am

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 2, 2015, 02:24 UTC
Message-ID
<xmqqtwo16111.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20151202005826.GE28197@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> The "[]" convention is a microformat used by Linux kernel folks. So it's
> not "whoops, we are stripping stuff not added by git". It is respecting
> a microformat used by the tool's authors.
>
> That being said, if we were choosing a default from scratch today, it
> might go the other way. But we aren't, and we have to deal with the
> burden of breaking existing scripts by flipping it.

And I do think it no longer is sensible to expect that it still is kernel-only convention. Any project that uses e-mail based workflow with Git have known how "[]" microformat works, may even have taken advantage of it to build their workflow around it, and flipping the default will only hurt them.

A project that chooses not to follow the convention can easily tweak a knob to keep using different conventions, so I do not see anything to change here.

Previous: Junio C HamanoNext: huebbe
Message 7 of 10 in “Bug: Incorrect stripping of the [PATCH] prefix in git-am”
  1. huebbeNov 25, 2015
  2. stefan.naewe@atlas-elektronik.comNov 25, 2015
  3. huebbeNov 25, 2015
  4. Jeff KingDec 2, 2015
  5. Stefan BellerDec 2, 2015
  6. Junio C HamanoDec 2, 2015
  7. Junio C HamanoDec 2, 2015
  8. huebbeDec 2, 2015
  9. Jeff KingDec 2, 2015
  10. huebbeDec 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.