Re: [PATCH] Makefile: POSIX windres

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2017, 03:10 UTC
Message-ID: <xmqqtw99x70u.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170107214110.3124-1-svnpenn@gmail.com>

Steven Penny <svnpenn@gmail.com> writes:

Show 7 quoted lines

> When environment variable POSIXLY_CORRECT is set, the "input -o output" syntax
> is not supported.
>
> http://cygwin.com/ml/cygwin/2017-01/msg00036.html
>
> Signed-off-by: Steven Penny <svnpenn@gmail.com>
> ---

Who other than cygwin build uses this target?  Git for Windows?

Hannes, Dscho, is this change OK with you guys?

Show 16 quoted lines

>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d861bd9..a2a1212 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1816,7 +1816,7 @@ $(SCRIPT_LIB) : % : %.sh GIT-SCRIPT-DEFINES
>  git.res: git.rc GIT-VERSION-FILE
>  	$(QUIET_RC)$(RC) \
>  	  $(join -DMAJOR= -DMINOR=, $(wordlist 1,2,$(subst -, ,$(subst ., ,$(GIT_VERSION))))) \
> -	  -DGIT_VERSION="\\\"$(GIT_VERSION)\\\"" $< -o $@
> +	  -DGIT_VERSION="\\\"$(GIT_VERSION)\\\"" -i $< -o $@
>  
>  # This makes sure we depend on the NO_PERL setting itself.
>  $(SCRIPT_PERL_GEN): GIT-BUILD-OPTIONS