Re: [PATCH] Makefile: POSIX windres

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 9, 2017, 08:09 UTC
Message-ID: <alpine.DEB.2.20.1701090903500.3469@virtualbox>
In-Reply-To: <xmqqtw99x70u.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Sun, 8 Jan 2017, Junio C Hamano wrote:

Show 11 quoted lines

> Steven Penny <svnpenn@gmail.com> writes:
> 
> > When environment variable POSIXLY_CORRECT is set, the "input -o
> > output" syntax is not supported.
> >
> > http://cygwin.com/ml/cygwin/2017-01/msg00036.html
> >
> > Signed-off-by: Steven Penny <svnpenn@gmail.com>
> > ---
> 
> Who other than cygwin build uses this target?  Git for Windows?

Yes, Git for Windows uses this target, as did msysGit (and I suspect Hannes' setup).

The resources are built correctly in Git for Windows SDK with this patch, and I just verified that the windres shipped with the last msysGit (AKA Git for Windows 1.x' SDK) handles the -i flag correctly, too. That is, at least windres.exe included in binutils-2.19.1-mingw32-bin.tar.gz (which was current at the time I updated msysGit on Feb 19 2009) can handle it.

So: ACK

Ciao, Dscho

P.S.: I applied this patch to Git for Windows' `master`: https://github.com/git-for-windows/git/commit/744120c602