Re: What's cooking in git.git (Jan 2017, #02; Sun, 15)

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 17, 2017, 20:32 UTC
Message-ID: <xmqqtw8xe8bp.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170117193639.mt3x3md3nbh2qgws@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> That was my general impression, too. But I seem to recall it was you in
> a nearby thread saying that:
>
>   if (foo)
> 	bar();
>   else {
>         one();
> 	two();
>   }
>
> was wrong. Maybe I misunderstood.

If it were a new code written like the above, that would have been fine. If a new code written with both sides inside {}, that would have been fine, too.

IIRC, it was that the original had {} on both, and a patch tried to turn that into the above, triggering "why are we churning between two acceptable forms?"