Re: What's cooking in git.git (Jan 2017, #02; Sun, 15)

From: Jeff King <peff@peff.net>
Date: Jan 17, 2017, 20:51 UTC
Message-ID: <20170117205126.sckxwrchlzzmsqui@sigill.intra.peff.net>
In-Reply-To: <xmqqtw8xe8bp.fsf@gitster.mtv.corp.google.com>

On Tue, Jan 17, 2017 at 12:32:26PM -0800, Junio C Hamano wrote:

Show 21 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > That was my general impression, too. But I seem to recall it was you in
> > a nearby thread saying that:
> >
> >   if (foo)
> > 	bar();
> >   else {
> >         one();
> > 	two();
> >   }
> >
> > was wrong. Maybe I misunderstood.
> 
> If it were a new code written like the above, that would have been
> fine.  If a new code written with both sides inside {}, that would
> have been fine, too.
> 
> IIRC, it was that the original had {} on both, and a patch tried to
> turn that into the above, triggering "why are we churning between
> two acceptable forms?"

Ah, OK. I didn't follow that discussion closely enough to realize that.

-Peff