Re: [PATCH v3 3/5] name-rev: add support to exclude refs by pattern match

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 18, 2017, 20:11 UTC
Message-ID: <xmqqtw8w86xc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170118000930.5431-4-jacob.e.keller@intel.com>

Jacob Keller <jacob.e.keller@intel.com> writes:

Show 6 quoted lines

> From: Jacob Keller <jacob.keller@gmail.com>
>
> Extend name-rev further to support matching refs by adding `--exclude`
> patterns. These patterns will limit the scope of refs by excluding any
> ref that matches at least one exclude pattern. Checking the exclude refs
> shall happen first, before checking the include --refs patterns.

I do not think we should have this "exclude first and then include" written down here, as it is an irrelevant implementation detail. The desired end result is that only refs that match at least one include and none of the exclude survive. You could implement it by first checking with include and then further narrowing that set by filtering those that match exclude (I am not saying that "include first then exclude" is better---I am saying that it is far less important than "at least one include and none of the exclude" to mention the order of application).

Show 6 quoted lines

> +--exclude=<pattern>::
> +	Do not use any ref whose name matches a given shell pattern. The
> +	pattern can be one of branch name, tag name or fully qualified ref
> +	name. If given multiple times, exclude refs that match any of the given
> +	shell patterns. Use `--no-exclude` to clear the list of exclude
> +	patterns.

Perhaps insert

    When used together with --refs, only those that match at least
    one of the --refs patterns and none of the --exclude patterns
    are used.

before "Use `--no-exclude` to clear"?