Re: [PATCH] Clear --exclude list after 'git rev-parse --all'

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 25, 2018, 23:43 UTC
Message-ID: <xmqqtvl9fv86.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181025104542.GA14455@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> An easy test is:
>
>   $ git rev-list --no-walk --exclude='*' --all --all
>   3289ca716320457af5d2dd550b716282ad22da11
>   ...a bunch of other tip commits...
>
>   $ git rev-parse --exclude='*' --all --all
>   [no output, but it should print those same tip commits]

I actually was hoping to see a test that contrasts "--all" (which lacks the alleged "clear exclude" bug) with another option that does have the "clear exclude", both used with rev-parse, i.e.

    $ git rev-parse --exclude='*' --glob='*' --glob='*'
    ... all the ref tips ...
    $ git rev-parse --exclude='*' --all --all
    ... ought to be equivalent, but is empty due to the bug ...

would have been a good demonstration that shows what bug we are fixing d(and would have been a good test to accompany the patch.