git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Clear --exclude list after 'git rev-parse --all'

From
AGAndreas Gruenbacher <agruenba@redhat.com>
Date
Oct 23, 2018, 19:17 UTC
Message-ID
<20181023191758.15138-1-agruenba@redhat.com>

Commit [1] added the --exclude option to revision.c. The --all, --branches, --tags, --remotes, and --glob options clear the exclude list. Shortly therafter, commit [2] added the same to 'git rev-parse', but without clearing the exclude list for the --all option. Fix that.

[1] e7b432c52 ("revision: introduce --exclude=<glob> to tame wildcards", 2013-08-30) [2] 9dc01bf06 ("rev-parse: introduce --exclude=<glob> to tame wildcards", 2013-11-01)

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 builtin/rev-parse.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c
index 0f09bbbf6..c71e3b104 100644
--- a/builtin/rev-parse.c
+++ b/builtin/rev-parse.c
@@ -764,6 +764,7 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
 			}
 			if (!strcmp(arg, "--all")) {
 				for_each_ref(show_reference, NULL);
+				clear_ref_exclusion(&ref_excludes);
 				continue;
 			}
 			if (skip_prefix(arg, "--disambiguate=", &arg)) {
-- 
2.17.2
Next: Junio C Hamano
Message 1 of 10 in “Clear --exclude list after 'git rev-parse --all'”
  1. Clear --exclude list after 'git rev-parse --all'Andreas Gruenbacher, Oct 23, 2018
  2. Junio C HamanoOct 24, 2018
  3. Andreas GruenbacherOct 24, 2018
  4. Junio C HamanoOct 24, 2018
  5. Andreas GruenbacherOct 24, 2018
  6. Jeff KingOct 25, 2018
  7. Junio C HamanoOct 25, 2018
  8. Jeff KingOct 26, 2018
  9. Junio C HamanoOct 27, 2018
  10. Jeff KingOct 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.