Re: [PATCH 0/4] mingw: prevent external PERL5LIB from interfering

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 31, 2018, 03:44 UTC
Message-ID: <xmqqtvl2ye3b.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <pull.62.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> An alternative approach which was rejected at the time (because it
> interfered with the then-ongoing work to compile Git for Windows using MS
> Visual C++) would patch the make_environment_block() function to skip the
> specified environment variables before handing down the environment block to
> the spawned process. Currently it would interfere with the mingw-utf-8-env
> patch series I sent earlier today
> [https://public-inbox.org/git/pull.57.git.gitgitgadget@gmail.com].

So the rejected approach that was not used in this series would interfere with the other one, but I do not have to worry about it because this series does not use that approach? I had to read the six lines above twice to figure out that it essentially is saying "I shouldn't care", but please let me know if I misread the paragraph and I need to care ;-)

> While at it, this patch series also cleans up house and moves the
> Windows-specific core.* variable handling to compat/mingw.c rather than
> cluttering environment.c and config.c with things that e.g. developers on
> Linux do not want to care about.

Or Macs. When I skimmed this series earlier, I found that patches 2 & 3 sensibly implemented to achieve this goal.

Show 23 quoted lines

>
> Johannes Schindelin (4):
>   config: rename `dummy` parameter to `cb` in git_default_config()
>   Allow for platform-specific core.* config settings
>   Move Windows-specific config settings into compat/mingw.c
>   mingw: unset PERL5LIB by default
>
>  Documentation/config.txt     |  6 ++++
>  cache.h                      |  8 -----
>  compat/mingw.c               | 58 +++++++++++++++++++++++++++++++++++-
>  compat/mingw.h               |  3 ++
>  config.c                     | 18 ++++-------
>  environment.c                |  1 -
>  git-compat-util.h            |  8 +++++
>  t/t0029-core-unsetenvvars.sh | 30 +++++++++++++++++++
>  8 files changed, 109 insertions(+), 23 deletions(-)
>  create mode 100755 t/t0029-core-unsetenvvars.sh
>
>
> base-commit: 4ede3d42dfb57f9a41ac96a1f216c62eb7566cc2
> Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-62%2Fdscho%2Fperl5lib-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-62/dscho/perl5lib-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/62