git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] config: rename `dummy` parameter to `cb` in git_default_config()

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 30, 2018, 18:40 UTC
Message-ID
<660c740fbc190274e1e124672d87abdada97ec2b.1540924800.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.62.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

This is the convention elsewhere (and prepares for the case where we may need to pass callback data).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 config.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/config.c b/config.c
index 4051e3882..3687c6783 100644
--- a/config.c
+++ b/config.c
@@ -1448,13 +1448,13 @@ static int git_default_mailmap_config(const char *var, const char *value)
 	return 0;
 }
 
-int git_default_config(const char *var, const char *value, void *dummy)
+int git_default_config(const char *var, const char *value, void *cb)
 {
 	if (starts_with(var, "core."))
 		return git_default_core_config(var, value);
 
 	if (starts_with(var, "user."))
-		return git_ident_config(var, value, dummy);
+		return git_ident_config(var, value, cb);
 
 	if (starts_with(var, "i18n."))
 		return git_default_i18n_config(var, value);
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 2 of 7 in “mingw: prevent external PERL5LIB from interfering”
  1. 0/4 mingw: prevent external PERL5LIB from interferingJohannes Schindelin via GitGitGadget, Oct 30, 2018
  2. 1/4 config: rename `dummy` parameter to `cb` in git_default_config()Johannes Schindelin via GitGitGadget, Oct 30, 2018
  3. 2/4 Allow for platform-specific core.* config settingsJohannes Schindelin via GitGitGadget, Oct 30, 2018
  4. 3/4 Move Windows-specific config settings into compat/mingw.cJohannes Schindelin via GitGitGadget, Oct 30, 2018
  5. 4/4 mingw: unset PERL5LIB by defaultJohannes Schindelin via GitGitGadget, Oct 30, 2018
  6. Junio C HamanoOct 31, 2018
  7. Johannes SchindelinOct 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.