git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sha1-name.c: Fix handling of revisions that contain paths with brackets

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 28, 2018, 19:59 UTC
Message-ID
<xmqqtvixo219.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181224080651.GA12708@duynguyen.home>
Duy Nguyen <pclouds@gmail.com> writes:
> Note that it also shows another corner case we need to be careful
> about: master^{/regex} syntax _can_ contain colons in regex. I suppose
> doing strchr to find the closing '}' here is better than what I did
> below.
Yes, the posted patch breaks master^{/foo:bar}, I suppose.
Previous: Duy NguyenNext: Stan Hu
Message 5 of 7 in “sha1-name.c: Fix handling of revisions that contain paths with brackets”
  1. sha1-name.c: Fix handling of revisions that contain paths with bracketsStan Hu, Dec 23, 2018
  2. sha1-name.c: Fix handling of revisions that contain paths with bracketsStan Hu, Dec 23, 2018
  3. sha1-name.c: Fix handling of revisions that contain paths with bracketsStan Hu, Dec 23, 2018
  4. Duy NguyenDec 24, 2018
  5. Junio C HamanoDec 28, 2018
  6. sha1-name.c: Fix handling of revisions that contain paths with bracketsStan Hu, Dec 29, 2018
  7. Junio C HamanoJan 2, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.