From: Junio C Hamano Date: Fri, 28 Dec 2018 19:59:46 GMT Subject: Re: [PATCH v2] sha1-name.c: Fix handling of revisions that contain paths with brackets Message-ID: In-Reply-To: <20181224080651.GA12708@duynguyen.home> Duy Nguyen writes: > Note that it also shows another corner case we need to be careful > about: master^{/regex} syntax _can_ contain colons in regex. I suppose > doing strchr to find the closing '}' here is better than what I did > below. Yes, the posted patch breaks master^{/foo:bar}, I suppose.