Re: [PATCH v2 0/4] Sideband the whole fetch v2 response

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 15, 2019, 19:50 UTC
Message-ID: <xmqqtvi9r98l.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <cover.1547581039.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 6 quoted lines

> @@ -474,6 +474,7 @@ void packet_reader_init(struct packet_reader *reader, int fd,
>  	reader->buffer = packet_buffer;
>  	reader->buffer_size = sizeof(packet_buffer);
>  	reader->options = options;
> +	reader->me = "git";
>  }

This was somewhat unexpected. I would have thought that an interdiff would be more like

        +	reader.me = "fetch-pack";
                if (using sideband-all) {
                        reader.use_sideband = 1;
        -		reader.me = "fetch-pack";
                }

Show 11 quoted lines

> +		case SIDEBAND_PRIMARY:
> +			if (reader->pktlen != 1)
> +				goto nonprogress_received;
> +			/*
> +			 * Since the packet contains nothing but the sideband
> +			 * designator, this is a keepalive packet. Wait for the
> +			 * next one.
> +			 */
> +			break;
> +		default: /* SIDEBAND_PROGRESS */
> +			;

OK.

Will replace.  Thanks.