Re: [PATCH v3 0/4] Sideband the whole fetch v2 response
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 17, 2019, 19:43 UTC
- Message-ID
- <xmqq5zunnk8b.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <cover.1547666330.git.jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 15 quoted lines
> /* > + * Inspects a multiplexed packet read from the remote. If this packet is a > + * progress packet and thus should not be processed by the caller, returns 0. > + * Otherwise, returns 1, releases scratch, and sets sideband_type. > * > + * If this packet is SIDEBAND_PROTOCOL_ERROR, SIDEBAND_REMOTE_ERROR, or a > + * progress packet, also prints a message to stderr. > + * > + * scratch must be a struct strbuf allocated by the caller. It is used to store > + * progress messages split across multiple packets. > */ > +int demultiplex_sideband(const char *me, char *buf, int len, > + int die_on_error, > + struct strbuf *scratch, > + enum sideband_type *sideband_type);
OK. That sounds like a sensible way to keep the leftover across calls.
Will queue.