git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] compat/obstack: fix -Wcast-function-type warnings

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 16, 2019, 04:16 UTC
Message-ID
<xmqqtvi9nsor.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190115235546.GF840@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 15 quoted lines
>> Well, first I'm not sure what changes Ævar meant to be backported.
>> Back then I briefly glanced at glibc's gitweb [1], but didn't see
>> anything remotely relevant to these compiler errors.
>
> So, I looked at the gnulib repository, where glibc got it's
> obstack.{c,h} from, and it does have a fix for this issue in commit
> 127ed6a3e (obstack: avoid potentially-nonportable function casts,
> 2014-11-04):
>
>   http://git.savannah.gnu.org/cgit/gnulib.git/commit?id=127ed6a3ea9c46452f079dee50382dc1f70ea796
>
> It chose basically the same approach as my fix, i.e. storing pointers
> to functions with different signatures in an union.  However,, the
> differences between our and their obstack.{c,h} are way too big to
> backport their patch.

Thanks. In the meantime, I've queued your fix in my tree, and with your digging, we can say we did due diligence and apply a local fix with conscience ;-).

Previous: SZEDER GáborNext: SZEDER Gábor
Message 18 of 33 in “On overriding make variables from the environment...”
  1. SZEDER GáborOct 16, 2018
  2. Jonathan NiederOct 16, 2018
  3. SZEDER GáborOct 16, 2018
  4. Jonathan NiederOct 16, 2018
  5. SZEDER GáborOct 17, 2018
  6. Johannes SchindelinOct 18, 2018
  7. Junio C HamanoOct 18, 2018
  8. 0/5 travis-ci: build with the right compilerSZEDER Gábor, Dec 20, 2018
  9. 1/5 compat/obstack: fix -Wcast-function-type warningsSZEDER Gábor, Dec 20, 2018
  10. Ævar Arnfjörð BjarmasonDec 20, 2018
  11. Junio C HamanoJan 10, 2019
  12. SZEDER GáborJan 11, 2019
  13. Junio C HamanoJan 11, 2019
  14. SZEDER GáborJan 11, 2019
  15. SZEDER GáborJan 15, 2019
  16. Jonathan NiederJan 16, 2019
  17. SZEDER GáborJan 17, 2019
  18. Junio C HamanoJan 16, 2019
  19. 2/5 .gitignore: ignore external debug symbols from GCC on macOSSZEDER Gábor, Dec 20, 2018
  20. 3/5 travis-ci: don't be '--quiet' when running the testsSZEDER Gábor, Dec 20, 2018
  21. 5/5 travis-ci: build with the right compilerSZEDER Gábor, Dec 20, 2018
  22. Johannes SchindelinJan 3, 2019
  23. 4/5 travis-ci: switch to Xcode 10.1 macOS imageSZEDER Gábor, Dec 20, 2018
  24. 0/5 travis-ci: build with the right compilerSZEDER Gábor, Jan 17, 2019
  25. 1/5 compat/obstack: fix -Wcast-function-type warningsSZEDER Gábor, Jan 17, 2019
  26. 2/5 .gitignore: ignore external debug symbols from GCC on macOSSZEDER Gábor, Jan 17, 2019
  27. 3/5 travis-ci: don't be '--quiet' when running the testsSZEDER Gábor, Jan 17, 2019
  28. Johannes SchindelinJan 17, 2019
  29. 4/5 travis-ci: switch to Xcode 10.1 macOS imageSZEDER Gábor, Jan 17, 2019
  30. 5/5 travis-ci: build with the right compilerSZEDER Gábor, Jan 17, 2019
  31. Johannes SchindelinJan 17, 2019
  32. SZEDER GáborJan 17, 2019
  33. Johannes SchindelinJan 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.