Re: [PATCH 1/5] compat/obstack: fix -Wcast-function-type warnings

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 11, 2019, 18:03 UTC
Message-ID: <xmqq4lafysve.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190111003743.GA840@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 13 quoted lines

> On Thu, Jan 10, 2019 at 01:22:00PM -0800, Junio C Hamano wrote:
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>  ...
>> > I.e. is this another case where we're blindly fixing bugs but should
>> > just re-import upstream's code instead?
>> 
>> Good point.  I am inclined to queue the remainder of the series
>> without this one for now.
>
> Note that without this first patch the linux-gcc build job will fail
> with the above compiler error, and that's the only build job that runs
> the test suite with all the misc test knobs (split-index,
> commit-graph, etc.) enabled.

I know.

The point is to give more incentive to try what was suggested earlier by Ævar (in short, "try to do the right thing, before hacking around locally in this project" ;-)