Re: [PATCH 1/3] diff-parseopt: correct variable types that are used by parseopt

From: Junio C Hamano <gitster@pobox.com>
Date: May 28, 2019, 19:23 UTC
Message-ID: <xmqqtvde1iyu.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190524092442.701-2-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Most number-related OPT_ macros store the value in an 'int'
> variable. Many of the variables in 'struct diff_options' have a
> different type, but during the conversion to using parse_options() I
> failed to notice and correct.

Why does this patch need to be so noisy? "unsigned identifier" is the same as "unsigned int identifier", isn't it?

That is, wouldn't this hunk ...

Show 6 quoted lines

> @@ -169,7 +169,7 @@ struct diff_options {
>  	const char *prefix;
>  	int prefix_length;
>  	const char *stat_sep;
> -	long xdl_opts;
> +	int xdl_opts;

... the only one that matters?