Re: [PATCH v2 0/3] fix diff-parseopt regressions

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2019, 18:03 UTC
Message-ID: <xmqq8supyw6r.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190529091116.21898-1-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> v2 reduces diff noise. My C is rusty (and probably holey too). For some
> reason I remember "unsigned" is equivalent to "unsigned short", not
> "unsigned int".

FWIW, I do not mind s/unsigned ident/unsigned int ident/ to make the type more explicit as a clean-up at some point. But I do think it is a good idea (and I like this v2 because of that) to do that as a separate step, and not mix with the real fix we see in the v2 1/3 patch.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.