Re: [PATCH] get_next_submodule(): format error string as an error

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2019, 16:15 UTC
Message-ID: <xmqqtvaj67v3.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190814155953.GC12093@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> On Wed, Aug 14, 2019 at 09:57:50AM +0000, Paolo Pettinato (ppettina) wrote:
>
>> Could not access submodule 'sm' # fails, plus no newline here :P!
>
> This part seems easy enough to fix.

Indeed, it is ;-)

Show 13 quoted lines

> diff --git a/submodule.c b/submodule.c
> index 0f199c5137..a5ba57ac36 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -1478,7 +1478,7 @@ static int get_next_submodule(struct child_process *cp,
>  			    !is_empty_dir(ce->name)) {
>  				spf->result = 1;
>  				strbuf_addf(err,
> -					    _("Could not access submodule '%s'"),
> +					    _("error: could not access submodule '%s'\n"),
>  					    ce->name);
>  			}
>  		}