Re: Git fetch bug in git 2.21+ "Could not access submodule '%s'"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 14, 2019, 17:56 UTC
- Message-ID
- <xmqqh86j637g.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <5a58b0eb-0690-c445-dbfd-bd4c5b614629@cisco.com>
"Paolo Pettinato (ppettina)" <ppettina@cisco.com> writes:
Show 10 quoted lines
> Thanks for the reply!
>
> On 14/08/2019 17:40, Junio C Hamano wrote:
>> Why is the user mucking with
>> that directory in the first place, and isn't the flagging of the
>> situation as an error, done with 26f80ccf ("submodule: migrate
>> get_next_submodule to use repository structs", 2018-11-28), a
>> bugfix? If not, why not?
>
> Not sure if you're implying here that this is not a bug; I'd say that:Yeah, sorry for a confused comment.
It does feel strange that the error behaviour depends on what is in the working tree for a "fetch", which is between two $GIT_DIR and does not involve the working tree on the receiving side (that brings us back to my earlier comment in the same message).