Re: [PATCH 1/2] clone: remove fetch_if_missing=0

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2019, 02:50 UTC
Message-ID: <xmqqtv78bibc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <84d8cee52e7c1dc030826c8caa0e107f80783b9c.1573604516.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 11 quoted lines

> diff --git a/connected.c b/connected.c
> index 36c4e5dedb..c337f5f7f4 100644
> --- a/connected.c
> +++ b/connected.c
> @@ -62,7 +62,8 @@ int check_connected(oid_iterate_fn fn, void *cb_data,
>  		 * received the objects pointed to by each wanted ref.
>  		 */
>  		do {
> -			if (!repo_has_object_file(the_repository, &oid))
> +			if (!repo_has_object_file_with_flags(the_repository, &oid,
> +							     OBJECT_INFO_SKIP_FETCH_OBJECT))

Wow, good find. Really good find. I guess the exercise to see if we can get rid of (or at least use less of) the big knob was a good idea.

Thanks, will queue.

>  				return 1;
>  		} while (!fn(cb_data, &oid));
>  		return 0;