git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 7, 2020, 03:15 UTC
Message-ID
<xmqqtv1wt29v.fsf@gitster.c.googlers.com>
In-Reply-To
<20200407010709.GK6369@camp.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> I'm fine with or without this change.  I think the original is clear to
> a native English speaker, but if we think it will be easier to parse or
> harder to misread with "made", then I'm in favor of the change.  I, of
> course, cannot speak for how either one reads to a non-native speaker.

I am not a native, but if I were writing it I would probably have written without the "made", so I guess I am in slight favor of not changing this part.

> I'm not sure it's fair to categorize it as a "grammatical mistake",
> though.

The patch certainly is an attempt to make the text better, but I agree that the patch does not correct any "mistake".

Thanks.
Previous: brian m. carlsonNext: Pratyush Yadav
Message 6 of 10 in “Add more issues in gitfaq”
  1. 0/2 Add more issues in gitfaqShourya Shukla, Apr 6, 2020
  2. 1/2 gitfaq: cleanup gitfaq.txtShourya Shukla, Apr 6, 2020
  3. Junio C HamanoApr 6, 2020
  4. Junio C HamanoApr 6, 2020
  5. brian m. carlsonApr 7, 2020
  6. Junio C HamanoApr 7, 2020
  7. Pratyush YadavApr 8, 2020
  8. Junio C HamanoApr 10, 2020
  9. 2/2 gitfaq: append the 'Common Issues' sectionShourya Shukla, Apr 6, 2020
  10. Junio C HamanoApr 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.