Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 7, 2020, 03:15 UTC
- Message-ID
- <xmqqtv1wt29v.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200407010709.GK6369@camp.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> I'm fine with or without this change. I think the original is clear to > a native English speaker, but if we think it will be easier to parse or > harder to misread with "made", then I'm in favor of the change. I, of > course, cannot speak for how either one reads to a non-native speaker.
I am not a native, but if I were writing it I would probably have written without the "made", so I guess I am in slight favor of not changing this part.
> I'm not sure it's fair to categorize it as a "grammatical mistake", > though.
The patch certainly is an attempt to make the text better, but I agree that the patch does not correct any "mistake".
Thanks.