Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Apr 7, 2020, 01:07 UTC
Message-ID: <20200407010709.GK6369@camp.crustytoothpaste.net>
In-Reply-To: <xmqqy2r8tbxn.fsf@gitster.c.googlers.com>

On 2020-04-06 at 23:46:28, Junio C Hamano wrote:

Show 9 quoted lines

> Shourya Shukla <shouryashukla.oo@gmail.com> writes:
> 
> > -How do I ignore changes to a tracked file?::
> > -	Git doesn't provide a way to do this.  The reason is that if Git needs
> > +How do I ignore changes made to a tracked file?::
> > +	Git doesn't provide a way to do this. The reason is that if Git needs
> 
> With or without 'made', I think the header says the same thing, but
> I guess it does not hurt to be explicit.

I'm fine with or without this change. I think the original is clear to a native English speaker, but if we think it will be easier to parse or harder to misread with "made", then I'm in favor of the change. I, of course, cannot speak for how either one reads to a non-native speaker.

I'm not sure it's fair to categorize it as a "grammatical mistake", though.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204