Re: [PATCH] core.abbrev <off|false|no> disables abbreviations

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 1, 2020, 19:14 UTC
Message-ID: <xmqqtuwhcnrl.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqblipebto.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Derrick Stolee <stolee@gmail.com> writes:
>
>>> +		else if (!strcasecmp(value, "false") ||
>>> +			 !strcasecmp(value, "no") ||
>>> +			 !strcasecmp(value, "off"))
>>> +			default_abbrev = the_hash_algo->hexsz;
>>
>> I'm not sure we need three synonyms for "no-abbrev" here.
>
> I do not particularly mind, but if we imitate the variety of various
> boolean false, I'd prefer to see the code to parse them shared to
> avoid them drifting apart over time.

Just a clarification.

 - I do not particularly mind having multiple synonyms.

 - I do mind these one-off strcasecmp that will cause them to drift
   away from what we do for the boolean 'false'.

Thanks.