git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] core.abbrev <off|false|no> disables abbreviations

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Sep 1, 2020, 23:37 UTC
Message-ID
<20200901233752.GC241078@camp.crustytoothpaste.net>
In-Reply-To
<xmqqblipebto.fsf@gitster.c.googlers.com>
On 2020-09-01 at 15:49:55, Junio C Hamano wrote:
Show 16 quoted lines
> I was in the vicinity of this code recently for reviewing another
> topic, but IIRC, 0 came from the UI level does get rounded up to the
> minimum accepted and never reach "default_abbrev", but if you manage
> to place 0 or -1 in default_abbrev here (e.g. with additional code,
> like the above part with the right hand side of the assignment
> updated), I think the value will propagate throughout the codepath
> and causes the downstream code to do the right thing.  0 will give
> you no-abbreviation (i.e. full length depending on the length of the
> hash) and -1 will give you the "scale as appropriate for the size of
> the object store".
> 
> I have mild preference for using 0 over hardcoded single "full
> length" here.  Even though we currently do not plan to allow
> multiple hashes in use simultaneously in a single invocation of Git,
> if that ever happens, we will regret hardcoding the_hash_algo->hexsz
> on the right hand side of the assignment here, like this patch does.

I think we have some commands that accept --abbrev=0 as a value meaning "no abbreviation", because I've touched that code as part of the SHA-256 work. So as far as the option value is concerned, I think it may make sense to use 0 for that meaning and just document it.

-- 
brian m. carlson: Houston, Texas, US
Previous: Junio C Hamano
Message 13 of 13 in “core.abbrev <off|false|no> disables abbreviations”
  1. core.abbrev <off|false|no> disables abbreviationsEric Wong, Sep 1, 2020
  2. Derrick StoleeSep 1, 2020
  3. Eric WongSep 1, 2020
  4. Derrick StoleeSep 1, 2020
  5. Junio C HamanoDec 22, 2020
  6. Eric WongDec 22, 2020
  7. Junio C HamanoDec 22, 2020
  8. Junio C HamanoDec 23, 2020
  9. Derrick StoleeDec 23, 2020
  10. brian m. carlsonDec 23, 2020
  11. Junio C HamanoSep 1, 2020
  12. Junio C HamanoSep 1, 2020
  13. brian m. carlsonSep 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.