Re: [PATCH] convert: clarify line ending conversion warning

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 4, 2022, 19:37 UTC
Message-ID: <xmqqtub8prm1.fsf@gitster.g>
In-Reply-To: <CAMMLpeQUZ3OfP=G-qKRjUVON=hninYEDQeeCrAdfM9maAZ3j7Q@mail.gmail.com>

Alex Henrie <alexhenrie24@gmail.com> writes:

Show 19 quoted lines

>> I have mixed feelings with this change, even though I agree that the
>> original is not good.  The first sentence of the updated text
>> already says that right now, the file ends with CRLF, and that the
>> conversion happen the next time you check out the file to the
>> working tree.  And that makes "For now ... still" totally redundant.
>>
>> Perhaps a single sentence, nothing more than
>>
>>         warning: in '%s', CRLF will be replaced by LF the next time
>>         you check it out
>>
>> is sufficient?  I dunno.
>
> I like your idea to move the file name to the start of the message,
> and I think that will address Ævar's concern as well.
>
> It doesn't matter to me whether the message is one sentence or two
> sentences. If you have a slight preference for one sentence then let's
> just do that.

"For now" smelled like sending a wrong and/or confusing message. Is it "for now" until we update the software, and with future versions of Git, "git add" will pretend as if the user immediately checked it out?

While I do not care too deeply between one and two sentences, getting rid of the seemingly redundant "For now" sentence will remove the source of such confusion, so ....