git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add basic http proxy tests

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 17, 2023, 00:30 UTC
Message-ID
<xmqqttzlm8uz.fsf@gitster.g>
In-Reply-To
<Y+6YgALh6L9m6rSX@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> Here is that patch. Even though it didn't lead me anywhere useful in
> debugging your problem, it may be worth picking up anyway just to get
> better test coverage.
> ...
>   - I'm using a single apache instance to proxy to itself. This seems to
>     work fine in practice, and we can check with a test that this rather
>     unusual setup is doing what we expect.
Cute.
Show 5 quoted lines
>   - I've put the proxy tests into their own script, and it's the only
>     one which loads the apache proxy config. If any platform can't
>     handle this (e.g., doesn't have the right modules), the start_httpd
>     step should fail and gracefully skip the rest of the script (but all
>     the other http tests in existing scripts will continue to run).
Nice.  I have to move it from 5563 to 5564, though.
Show 8 quoted lines
>   - On the client side, we test two situations with credentials: when
>     they are present in the url, and when the username is present but we
>     prompt for the password. I think we should be able to handle the
>     case that _neither_ is present, but an HTTP 407 causes us to prompt
>     for them. However, this doesn't seem to work. That's either a bug,
>     or at the very least an opportunity for a feature, but I punted on
>     it for now. The point of this patch is just getting basic coverage,
>     and we can explore possible deficiencies later.
OK.
Thanks.
Previous: Jeff KingNext: Jeff King
Message 4 of 5 in “Bug: git behind proxy is broken in 2.34.1”
  1. tm-uzr3z@entrap.deFeb 16, 2023
  2. Jeff KingFeb 16, 2023
  3. add basic http proxy testsJeff King, Feb 16, 2023
  4. Junio C HamanoFeb 17, 2023
  5. Jeff KingFeb 17, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.