Re: [PATCH] add basic http proxy tests

From: Jeff King <peff@peff.net>
Date: Feb 17, 2023, 00:43 UTC
Message-ID: <Y+7NwQer53hP9ekm@coredump.intra.peff.net>
In-Reply-To: <xmqqttzlm8uz.fsf@gitster.g>

On Thu, Feb 16, 2023 at 04:30:28PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> >   - I've put the proxy tests into their own script, and it's the only
> >     one which loads the apache proxy config. If any platform can't
> >     handle this (e.g., doesn't have the right modules), the start_httpd
> >     step should fail and gracefully skip the rest of the script (but all
> >     the other http tests in existing scripts will continue to run).
> 
> Nice.  I have to move it from 5563 to 5564, though.

Ah, yeah. These number collisions are annoying.

Also, I note that our http client tests have spilled over into t556x now, making the t556x_common script a bit of a misnomer (it handles http-backend stuff). I'm not sure if we should be reordering more (which is a lot of hassle) or perhaps just giving that helper a script a more descriptive name. Or doing nothing. It is not that big a deal, just something I noticed while searching for an unused number.

-Peff