Re: [PATCH v3 5/5] diff: the -w option breaks --exit-code for --raw and other output modes

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2023, 22:16 UTC
Message-ID: <xmqqttssnir4.fsf@gitster.g>
In-Reply-To: <20230821210058.GD1800481@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> Alternatively, we could put it in the caller, like so:
>
> diff --git a/diff.c b/diff.c
> index 78f4e7518f..e7281e75eb 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -6528,6 +6528,7 @@ void diff_flush(struct diff_options *options)
>  			if (check_pair_status(p))
>  				flush_one_pair(p, options);
>  		}
> +		options->found_changes = !!q->nr;
>  		separator++;
>  	}

Yup, I suspect they amount to the same thing in practice, but I couldn't come up with a good explanation to give casual readers of the conditional call to flush_one_pair() a few lines above why this is correct.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.