Re: [PATCH v3 0/5] fix interactions with "-w" and "--exit-code"

From: Jeff King <peff@peff.net>
Date: Aug 21, 2023, 21:02 UTC
Message-ID: <20230821210250.GE1800481@coredump.intra.peff.net>
In-Reply-To: <20230818235932.3253552-1-gitster@pobox.com>

On Fri, Aug 18, 2023 at 04:59:27PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Paul Watson reported that "diff --no-index --exit-code
> --ignore-all-space" does not work when used with "--shortstat".  It
> turns out that this is not limited to "--no-index" mode, and it is
> not limited to "--shortstat".  Anything that does not use the "--patch"
> machinery to discover the content level differences ignored --exit-code
> when used with options like "-w" and always exited with 0.  In fact,
> even the "--patch" machinery was slightly faulty in corner cases.
> 
> And here is another round to fix it.
> Previous one is at https://lore.kernel.org/git/20230817222949.3835424-1-gitster@pobox.com/

This looks good to me. I left some musings, but I don't think there is anything that merits a re-roll (you might want to fix-up a commit message typo locally).

Thanks for running with it. It's much nicer than v1. :)

-Peff