Re: [PATCH 1/2] t/t6300: introduce test_bad_atom()

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2023, 23:09 UTC
Message-ID: <xmqqttro787y.fsf@gitster.g>
In-Reply-To: <xmqqy1h078tf.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

>> +	case "$1" in
>> +	head) ref=refs/heads/main ;;
>> +	 tag) ref=refs/tags/testtag ;;
>> +	 sym) ref=refs/heads/sym ;;
>> +	   *) ref=$1 ;;
>> +	esac
>
> Somehow this indirection makes the two examples we see below harder
> to understand.  ... It does not help that both 'head' and
> 'sym' refer to a local branch ...

Ah, this "sym" thing is a (rather unnatural) symbolic ref inside refs/heads/ hierarchy, so the naming makes halfway sense. As it is also used in test_atom, I no longer find it all that much disturbing.

Everything else I said in my review still stands, I would think.

Thanks.