git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t/t6300: introduce test_bad_atom()

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 20, 2023, 23:21 UTC
Message-ID
<xmqqmsxg77nh.fsf@gitster.g>
In-Reply-To
<xmqqy1h078tf.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
>> +test_bad_atom tag 'taggeremail:localpart trim' \
>> +	'fatal: unrecognized %(taggeremail) argument:  trim'
>
> It is strange to see double SP before 'trim' in this error message.
> Are we etching a code mistake in stone here?  Wouldn't the error
> message say "...argument: localpart trim" instead, perhaps?

I tried. The fatal message does say ...argument: localpart trim" as I suspected, when you ask for 'taggeremail:localpart trim'.

I think I know what is going on. With the [PATCH 1/2] as-is, this piece does not pass. But because the error message from parsing gets broken by [PATCH 2/2], after applying [PATCH 2/2], the error message will become what the above test expects, hiding the new breakage in the code. And it probably was not noticed before you sent the patches, because you did not test [PATCH 1/2] alone.

Previous: Junio C HamanoNext: Kousik Sanagavarapu
Message 5 of 11 in “Add mailmap support to ref-filter”
  1. 0/2 Add mailmap support to ref-filterKousik Sanagavarapu, Sep 20, 2023
  2. 1/2 t/t6300: introduce test_bad_atom()Kousik Sanagavarapu, Sep 20, 2023
  3. Junio C HamanoSep 20, 2023
  4. Junio C HamanoSep 20, 2023
  5. Junio C HamanoSep 20, 2023
  6. Kousik SanagavarapuSep 21, 2023
  7. 2/2 ref-filter: add mailmap supportKousik Sanagavarapu, Sep 20, 2023
  8. 0/3 Add mailmap support to ref-filterKousik Sanagavarapu, Sep 25, 2023
  9. 1/3 t/t6300: cleanup test_atomKousik Sanagavarapu, Sep 25, 2023
  10. 2/3 t/t6300: introduce test_bad_atomKousik Sanagavarapu, Sep 25, 2023
  11. 3/3 ref-filter: add mailmap supportKousik Sanagavarapu, Sep 25, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.