git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/6] refs: provide detailed error messages when using batched update

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 21, 2026, 18:12 UTC
Message-ID
<xmqqtsweu96c.fsf@gitster.g>
In-Reply-To
<20260120-633-regression-lost-diagnostic-message-when-pushing-non-commit-objects-to-refs-heads-v3-0-e0edb29acbef@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 31 quoted lines
> The refs namespace uses an error buffer to capture details about failed
> reference updates. However when we added batched update support to
> reference transactions, these messages were never propagated, instead
> only an error code pertaining to the type of failure was propagated.
>
> Currently, there are three regions which utilize batched updates:
>
>   - git update-ref --batch-updates
>   - git fetch
>   - git receive-pack
>
> While 'git update-ref --batch-updates' was a newly introduced flag, both
> 'git fetch' and 'git receive-pack' were pre-existing. Before using
> batched updates, they provided more detailed error messages to the user,
> but this changed with the introduction of batched updates. This is a
> regression in their workings.
>
> This patch series fixes this, by passing the detailed error message and
> utilizing it whenever available. The regression was reported by Elijah
> Newren [1] and based on the patch submitted by Jeff King [2].
>
> [1]: https://lore.kernel.org/all/CABPp-BGL2tJR4dPidQuFcp-X0_VkVTknCY-0Zgo=jHVGv_P=wA@mail.gmail.com/
> [2]: https://lore.kernel.org/all/20251224081214.GA1879908@coredump.intra.peff.net/
>
> ---
> Changes in v3:
> - Drop the first commit.
> - For the last commit, where we delay 'git fetch' status information,
>   delay all information to the end. Also use a list to compliment the
>   existing strmap, this ensures that the order is maintained.
> - Link to v2: https://patch.msgid.link/20260116-633-regression-lost-diagnostic-message-when-pushing-non-commit-objects-to-refs-heads-v2-0-925a0e9c7f32@gmail.com
Thanks.  These look good.
Previous: Karthik Nayak
Message 11 of 11 in “refs: provide detailed error messages when using batched update”
  1. 0/6 refs: provide detailed error messages when using batched updateKarthik Nayak, Jan 20, 2026
  2. 1/6 refs: skip to next ref when current ref is rejectedKarthik Nayak, Jan 20, 2026
  3. 2/6 refs: add rejection detail to the callback functionKarthik Nayak, Jan 20, 2026
  4. 3/6 update-ref: utilize rejected error details if availableKarthik Nayak, Jan 20, 2026
  5. 4/6 fetch: utilize rejected ref error detailsKarthik Nayak, Jan 20, 2026
  6. 5/6 receive-pack: utilize rejected ref error detailsKarthik Nayak, Jan 20, 2026
  7. 6/6 fetch: delay user information post committing of transactionKarthik Nayak, Jan 20, 2026
  8. Phillip WoodJan 21, 2026
  9. Junio C HamanoJan 21, 2026
  10. Karthik NayakJan 22, 2026
  11. Junio C HamanoJan 21, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.