git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 6/6] fetch: delay user information post committing of transaction

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jan 22, 2026, 09:05 UTC
Message-ID
<CAOLa=ZRO1gH_pdo6Z1xpx5N5u=Unfhq7wyV8EHUiB0zp1+AhJw@mail.gmail.com>
In-Reply-To
<67808128-5f41-4ae5-b224-a76048cd82c8@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 32 quoted lines
> Hi Karthik
>
> On 20/01/2026 09:59, Karthik Nayak wrote:
>
>> +struct ref_update_display_info {
>> +	bool failed;
>> +	char success_code;
>> +	char fail_code;
>> +	const char *summary;
>> +	const char *fail_detail;
>> +	const char *success_detail;
>> +	const char *ref;
>> +	const char *remote;
>> +	struct object_id old_oid;
>> +	struct object_id new_oid;
>> +};
>
> I was expecting that we'd pass around a struct like
>
> struct ref_update_display_info_array {
> 	size_t alloc, nr;
> 	ref_update_display_info *info;
> };
>
> rather than passing a pointer, count pair as separate parameters. That
> would also allow us to use ALLOC_GROW() rather than reallocating the
> array each time we append to it which is rather inefficient.
>
> Thanks
>
> Phillip
>

That's fair, I was considering an array and didn't see the need, but using 'ALLOC_GROW()' does make it simpler, plus we'd totally remove the need for the double pointer. Will change. Thanks!

Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 11 in “refs: provide detailed error messages when using batched update”
  1. 0/6 refs: provide detailed error messages when using batched updateKarthik Nayak, Jan 20, 2026
  2. 1/6 refs: skip to next ref when current ref is rejectedKarthik Nayak, Jan 20, 2026
  3. 2/6 refs: add rejection detail to the callback functionKarthik Nayak, Jan 20, 2026
  4. 3/6 update-ref: utilize rejected error details if availableKarthik Nayak, Jan 20, 2026
  5. 4/6 fetch: utilize rejected ref error detailsKarthik Nayak, Jan 20, 2026
  6. 5/6 receive-pack: utilize rejected ref error detailsKarthik Nayak, Jan 20, 2026
  7. 6/6 fetch: delay user information post committing of transactionKarthik Nayak, Jan 20, 2026
  8. Phillip WoodJan 21, 2026
  9. Junio C HamanoJan 21, 2026
  10. Karthik NayakJan 22, 2026
  11. Junio C HamanoJan 21, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.