Re: [PATCH 0/2] xdiff: Remove unneeded members from xrecord_t and xdlclass_t

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2026, 17:35 UTC
Message-ID: <xmqqtsw8i8fa.fsf@gitster.g>
In-Reply-To: <cover.1769424529.git.phillip.wood@dunelm.org.uk>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 11 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> This series has a couple of cleanups on top of 'en/xdiff-cleanup-2'
> that reduce the sizes of the xrecord_t and xdlclass_t. Unfortunately
> they conflict with 'en/xdiff-cleanup-3' in seen, in particular with
> db8a50ca6b9 (xdiff: don't waste time guessing the number of lines,
> 2026-01-02). I'm not particularly convinced that moving the call to
> xdl_classify_record() out of xdl_prepare_ctx() in that commit is
> a good idea, but if we decide that we do want to stop classifying
> lines in xdl_prepare_ctx() we can start passing the hashes out in a
> separate array rather than wasting space in xrecord_t.

Both patches look well reasoned and sensible.

It is unfortunate that the en/xdiff-cleanup-3 wants to pull these fields in a different direction, but the topic has been dormant for quite a while, so let's tentatively kick it out of 'seen' and see how well this one does, until we decide how to consolidate the two topics. Thanks.