Re: [PATCH 0/2] xdiff: Remove unneeded members from xrecord_t and xdlclass_t
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 10, 2026, 20:39 UTC
- Message-ID
- <xmqqikc4xri7.fsf@gitster.g>
- In-Reply-To
- <xmqqtsw8i8fa.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 15 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes: > >> From: Phillip Wood <phillip.wood@dunelm.org.uk> >> >> This series has a couple of cleanups on top of 'en/xdiff-cleanup-2' >> that reduce the sizes of the xrecord_t and xdlclass_t. Unfortunately >> they conflict with 'en/xdiff-cleanup-3' in seen, in particular with >> db8a50ca6b9 (xdiff: don't waste time guessing the number of lines, >> 2026-01-02). I'm not particularly convinced that moving the call to >> xdl_classify_record() out of xdl_prepare_ctx() in that commit is >> a good idea, but if we decide that we do want to stop classifying >> lines in xdl_prepare_ctx() we can start passing the hashes out in a >> separate array rather than wasting space in xrecord_t. > > Both patches look well reasoned and sensible.
I was hoping that these two patches will get reviewed by somebody else in adddition to mine, but unfortunately nothing happened. I am inclined to merge it down so that the other topic can have a stable base to be rebased.
Opinions?