Re: [PATCH v2] send-email: clarify missing subject error
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 10, 2026, 21:09 UTC
- Message-ID
- <xmqqtsp165tj.fsf@gitster.g>
- In-Reply-To
- <pull.2375.v2.git.git.1786384412423.gitgitgadget@gmail.com>
"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 12 quoted lines
> +test_expect_success $PREREQ 'missing subject omits Perl location' ' > + cat >no-subject.patch <<-\EOF && > + This is the body. > + EOF > + test_must_fail git send-email \ > + --dry-run \ > + --from="Example <nobody@example.com>" \ > + --to=nobody@example.com \ > + no-subject.patch 2>actual && > + cat >expect <<-\EOF && > + No '\''Subject:'\'' line in '\''no-subject.patch'\'' > + EOF
OK. We require the message to exactly be this one (not starting with this substring), which makes sure we are not getting the line numbers from die. Good.
Will queue. This round looks perfect. Let's mark it for 'next'.
Thanks.