git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: clarify missing subject error

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 10, 2026, 15:28 UTC
Message-ID
<xmqqh5l26ll7.fsf@gitster.g>
In-Reply-To
<CAHwyqnVWgNThSPnPBVwOb11S9MSjD0R3BRg1ci6yEQR+Vn1kXg@mail.gmail.com>
Harald Nordgren <haraldnordgren@gmail.com> writes:
Show 17 quoted lines
>> An input file to the 'git send-email' program is often the output
>> of 'git format-patch'.  Such a file begins with a UNIX 'From '
>> line, followed by email headers such as 'From:', 'Date:', and
>> 'Subject:'.  The 'Subject:' line cannot be the first line of
>> the file in this case, yet it is a valid input.
>>
>> The only condition that this subroutine flags as an error is when
>> the file lacks a subject line.  "No 'Subject:' line in '%s'\n" is a
>> clear message to display and is an improvement over the original.
>>
>> However, the fact that the first line does not start with
>> "Subject:" is irrelevant to the basis of the subroutine's
>> decision to issue an error, I think.
>
> Yeah, that makes sense, so maybe we don't need to focus on it being
> the first line, but Subject needs to be there somewhere before the
> body.

Yeah, the curious thing is that the subroutine with the loop is happy as long as it finds "^Subject: " somewhere, not necessarily before the first blank line.

That is why I said "No 'Subject: ' line in '%s'\n" is clear enough and an improvement over the original. Anything else will add lie to it.

Thanks.
Previous: Harald NordgrenNext: Harald Nordgren via GitGitGadget
Message 4 of 6 in “send-email: clarify missing subject error”
  1. send-email: clarify missing subject errorHarald Nordgren via GitGitGadget, Aug 9, 2026
  2. Junio C HamanoAug 9, 2026
  3. Harald NordgrenAug 10, 2026
  4. Junio C HamanoAug 10, 2026
  5. send-email: clarify missing subject errorHarald Nordgren via GitGitGadget, Aug 10, 2026
  6. Junio C HamanoAug 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.