Re: [PATCH v2] doc: fix AsciiDoc syntax
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 20, 2026, 19:03 UTC
- Message-ID
- <xmqqtslbpbpa.fsf@gitster.g>
- In-Reply-To
- <pull.2496.v2.git.git.1795199746309.gitgitgadget@gmail.com>
"Ophir Bleicher via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 13 quoted lines
> From: Ophir Bleicher <ophirble@gmail.com> > > The Documentation/MyFirstContribution.adoc file accidentally used > Markdown syntax for a link: > > [here](https://gitgitgadget.github.io/#...) > > Fixed it to use AsciiDoc: > > https://gitgitgadget.github.io/#...[here] > > Signed-off-by: Ophir Bleicher <ophirble@gmail.com> > ---
The exact same tense and mood suggestion applies to this commit message, too. "uses" and "Fix". I can locally tweak them while queuing, so no need to resend if you are OK with it.
Show 42 quoted lines
> doc: fix AsciiDoc syntax > > Difference from v1: > > * Change link text > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v2 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v2 > Pull-Request: https://github.com/git/git/pull/2496 > > Range-diff vs v1: > > 1: 748ac69283 ! 1: cf26060e59 doc: fix AsciiDoc syntax > @@ Documentation/MyFirstContribution.adoc: either with the "New pull request" butto > > The differences between using `gitgitgadget/git` and `git/git` as your base can > -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror) > -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here] > ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.] > > Review the PR's title and description, as they're used by GitGitGadget > respectively as the subject and body of the cover letter for your change. Refer > > > Documentation/MyFirstContribution.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc > index c58253fd54..73dab5f7c9 100644 > --- a/Documentation/MyFirstContribution.adoc > +++ b/Documentation/MyFirstContribution.adoc > @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull > request" button that may appear with the name of your newly pushed branch. > > The differences between using `gitgitgadget/git` and `git/git` as your base can > -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror) > +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.] > > Review the PR's title and description, as they're used by GitGitGadget > respectively as the subject and body of the cover letter for your change. Refer > > base-commit: f7de81456940dd6f3274e461149bba12965de609