Re: [PATCH] doc: fix AsciiDoc syntax
- From
Ben Knoble <ben.knoble@gmail.com>
- Date
- Nov 20, 2026, 17:54 UTC
- Message-ID
- <93127462-BCFD-4086-B19D-4B640F515140@gmail.com>
- In-Reply-To
- <pull.2496.git.git.1795194752259.gitgitgadget@gmail.com>
Show 12 quoted lines
> Le 20 nov. 2026 à 12:31, Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com> a écrit : > > From: Ophir Bleicher <ophirble@gmail.com> > > The Documentation/MyFirstContribution.adoc file accidentally used > Markdown syntax for a link: > > [here](https://gitgitgadget.github.io/#...) > > Fixed it to use AsciiDoc: > > https://gitgitgadget.github.io/#...[here]
Good catch.
While we’re at it, « here » is generally discouraged as link text. It’s not particularly accessible for screen-readers, for example.
Show 21 quoted lines
> Signed-off-by: Ophir Bleicher <ophirble@gmail.com> > --- > doc: fix AsciiDoc syntax > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v1 > Pull-Request: https://github.com/git/git/pull/2496 > > Documentation/MyFirstContribution.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc > index c58253fd54..3b531b24fa 100644 > --- a/Documentation/MyFirstContribution.adoc > +++ b/Documentation/MyFirstContribution.adoc > @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull > request" button that may appear with the name of your newly pushed branch. > > The differences between using `gitgitgadget/git` and `git/git` as your base can > -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror) > +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
So perhaps we could reword this to something like
Further [differences between …] are described online.
with the brackets marking the link text?
Show 7 quoted lines
> Review the PR's title and description, as they're used by GitGitGadget > respectively as the subject and body of the cover letter for your change. Refer > > base-commit: f7de81456940dd6f3274e461149bba12965de609 > -- > gitgitgadget >