git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/15] builtin/add.c: rearrange xcalloc arguments

From
Junio C Hamano <gitster@pobox.com>
Date
May 27, 2014, 22:41 UTC
Message-ID
<xmqqsinueteo.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAPig+cTmyBzroDOnqEb_GWqhcbgbK27pT3=3VCVOnj13=C4CfA@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 7 quoted lines
> If you do re-roll, perhaps consider simplifying the commit messages.
> The patch itself states concisely and precisely what is being changed;
> the lengthy prose description doesn't really add anything (and makes
> more work for you and the reader of the message). It might be
> sufficient to use a single-line (Subject:) commit message, like this:
>
>     builtin/add.c: fix order of xcalloc arguments
Yeah, I like that.

I do not think it is worth doing this change starting from maint, so I've dropped this one and a few others that did not apply to master and queued the remainder to 'pu'.

Previous: Eric SunshineNext: Jeremiah Mahler
Message 9 of 28 in “Rearrange xcalloc arguments”
  1. 00/15 Rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  2. 01/15 builtin/add.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  3. Jeremiah MahlerMay 26, 2014
  4. Brian GesiakMay 27, 2014
  5. Jeremiah MahlerMay 27, 2014
  6. Eric SunshineMay 27, 2014
  7. Brian GesiakMay 27, 2014
  8. Eric SunshineMay 27, 2014
  9. Junio C HamanoMay 27, 2014
  10. Jeremiah MahlerMay 28, 2014
  11. Brian GesiakMay 28, 2014
  12. 02/15 builtin/ls-remote.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  13. 03/15 builtin/remote.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  14. 04/15 commit.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  15. 05/15 config.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  16. 06/15 diff.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  17. 07/15 hash.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  18. 08/15 hash.h: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  19. 09/15 http-push.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  20. 10/15 imap-send.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  21. Jeremiah MahlerJun 10, 2014
  22. 11/15 notes.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  23. 12/15 pack-revindex.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  24. 13/15 reflog-walk.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  25. 14/15 remote.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  26. 15/15 transport-helper.c: rearrange xcalloc argumentsBrian Gesiak, May 26, 2014
  27. Jeremiah MahlerMay 26, 2014
  28. Jeff KingMay 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.