Re: [PATCH 0/3] Win32: nanosecond-precision file times

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 12, 2015, 23:38 UTC
Message-ID: <xmqqsieaog4a.fsf@gitster.dls.corp.google.com>
In-Reply-To: <54DD2FDA.7030604@gmail.com>

Karsten Blees <karsten.blees@gmail.com> writes:

Show 18 quoted lines

> This is more about copying 'old' things around, which usually also
> copies mtime on Windows. E.g.:
>
>   # create two files with slightly different mtime
>   for i in {1..10}; do (echo "v1" >> test); done &&
>   for i in {1..10}; do (echo "v2" >> test2); done
>   # wait a bit so that '.git/index' is always newer than 'test' / 'test2'
>   sleep 1
>   git add test
>   git commit -m v1
>   # copy test2 over test (similar to 'cp -p', but native 'copy' also
>   # copies mtime nanoseconds)
>   cmd //c "copy /y test2 test"
>   git add test
>   git commit -m v2
>
> Without these patches, git does not detect the change, and the second
> git add / git commit are noops.

We do have sec/nsec fields in cache_time structure, so I have nothing against updating the msysGit port to fill that value.

I was and am just reacting to the fact that this is sold as if it "fixes" something. It doesn't fundamentally change the fact that mtime that does not follow the semantics Dscho mentioned in his earlier message does not work well with Git.

Having said that, even with such a patch, as long as the system is sufficiently fast, test and test2 will have nonoseconds identical timestamp and you would have the same issue, no?

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.