Re: Re: [PATCH 0/3] Win32: nanosecond-precision file times

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Feb 12, 2015, 22:30 UTC

Message-ID

<db4e2b740bef943fb1adaf2b22893136@www.dscho.org>

In-Reply-To

<xmqqbnkysygl.fsf@gitster.dls.corp.google.com>

Hi,

On 2015-02-12 20:48, Junio C Hamano wrote:

> Karsten Blees <karsten.blees@gmail.com> writes:
> 
>> This patch series was inspired by the problem that Git does not
>> detect changed file content if st_size, st_mtime and st_ctime
>> are unchanged. This was apparently caused by VSS2Git resetting
>> mtime to a value in the past. [1]
>>
>> I believe (or rather hope) that all involved in the discussion
>> agree that Git cannot reasonably be expected to detect changed
>> file content if file time(s) are reset on purpose.
>>
>> However, some users have expressed concerns that 'same size and
>> mtime' [2] may theoretically happen by chance in daily operation.
> 
> Hmph.
> 
> Haven't we already accepted that it is not just "may theoretically
> happen" and had counter-measures in racy-git detection machinery
> for quite some time?

I agree that the "racy-git" reference is more of a red herring; it appears that the report Karsten referred to is based on a different understanding of the mtime than mine (it is purported that the mtime of a file should reflect the time when it entered the repository, rather than the time when the file was written to disk).

Please let that not distract you.

This patch series has merits on the basis of populating st_mtim.tv_nsec already. We can provide this information in the common case (i.e. NTFS, *not* FAT), so we should.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.