Re: [PATCH] http: add option to try authentication without username

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 15, 2016, 21:39 UTC
Message-ID: <xmqqsi0tpsa5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160215203659.GB57185@vauxhall.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 9 quoted lines

> On Mon, Feb 15, 2016 at 03:34:51PM -0500, Jeff King wrote:
> ...
>> So I think this hack should remain purely at the curl level, and never
>> touch the credential struct at all.
>> 
>> Which is a shame, because I think Eric's suggestion is otherwise much
>> more readable. :)
>
> Yes, I agree.  That would have been a much nicer and smaller change.

Alright, reading all reviews and taking them into account, the original, when a Sign-off is added, would be acceptable, it seems.

Thanks.