Re: [PATCH] http: add option to try authentication without username
On Mon, Feb 15, 2016 at 03:34:51PM -0500, Jeff King wrote:
Show 11 quoted lines
> On Mon, Feb 15, 2016 at 08:29:37PM +0000, brian m. carlson wrote:
> > That would work. I was concerned about the credential_fill call
> > actually prompting the user, but it appears that it doesn't do that if
> > the password already exists. I don't know if we want to rely on that
> > functionality, though.
>
> Yeah, credential_fill() will treat that as a noop, as it is no different
> than getting "https://user:pass@example.com" in the URL in the first
> place. But it will _also_ send the result to credential_approve() and
> credential_reject(), which you probably don't want (because you do not
> want to store these useless dummy credentials in your keystore).
Show 5 quoted lines
> So I think this hack should remain purely at the curl level, and never
> touch the credential struct at all.
>
> Which is a shame, because I think Eric's suggestion is otherwise much
> more readable. :)
Yes, I agree. That would have been a much nicer and smaller change.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
brian m. carlson <sandals@crustytoothpaste.net>