Re: [PATCH 4/5] t/t5520: modify tests to reduce common code

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2016, 20:13 UTC
Message-ID: <xmqqshz9vy8e.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1459258200-32444-5-git-send-email-mehul.jain2029@gmail.com>

Mehul Jain <mehul.jain2029@gmail.com> writes:

Show 5 quoted lines

> There exist three groups of tests which have repetitive lines of code.
>
> Introduce two functions test_rebase_autostash() and
> test_rebase_no_autostash() to reduce the number of lines. Also introduce
> loops to futher reduce the current implementation.

Sound like sensible idea.

Show 7 quoted lines

> +for i in true false
> +	do
> +		test_expect_success "pull --rebase --autostash & rebase.autostash=$i" '
> +			test_config rebase.autostash $i &&
> +			test_rebase_autostash
> +		'
> +	done

The lines between do..done is over-indented (will locally fix--no need to resend).