Re: [PATCH 5/5] t/t5520: test --[no-]autostash with pull.rebase=true

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Apr 4, 2016, 18:21 UTC
Message-ID: <vpqy48ti6ad.fsf@anie.imag.fr>
In-Reply-To: <CA+DCAeTm7wjgdjLwR__pcyev-EsqecdAT8xdGEFfuekg4ToKSA@mail.gmail.com>

Mehul Jain <mehul.jain2029@gmail.com> writes:

Show 12 quoted lines

> On Mon, Apr 4, 2016 at 10:22 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> I think it would be much simpler to drop the loop, and write instead
>> something like (untested):
>
> I tested it (with few minor changes), and worked fine.
>
> test_autostash () {
>         OLDIFS=$IFS
>         IFS='='
>         set -- $*
>         IFS=$OLDIFS

This $IFS dance is not needed. If you need to split variable and value, then just pass two arguments on the caller side.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/