Re: [PATCH v4 3/4] imap_send: setup_curl: retreive credentials if not set in config file

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2017, 04:50 UTC
Message-ID: <xmqqshfoy38u.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <accffa40-3559-5f65-3149-aaa86a2278fc@morey-chaisemartin.com>

Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com> writes:

Show 13 quoted lines

>  
> +	if (cred.username)
> +		if (res == CURLE_OK)
> +			credential_approve(&cred);
> +#if LIBCURL_VERSION_NUM >= 0x070d01
> +		else if (res == CURLE_LOGIN_DENIED)
> +#else
> +		else
> +#endif
> +			credential_reject(&cred);
> +
> +	credential_clear(&cred);
> +

As my copy of GCC seemed to be worried about readers getting confused by the if/else cascade, I'd place an extra pair of braces around this, i.e.

	if (cred.username) {
		if (res == CURLE_OK)
			credential_approve(&cred);
		else /* or "else if DENIED" */
			credential_reject(&cred);
	}
	credential_clear(&cred);

while queuing this patch.