git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 4/4] imap-send: use curl by default when possible

From
Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
Date
Sep 14, 2017, 07:52 UTC
Message-ID
<ee4cb3a1-3219-411f-cc05-6874da202b32@morey-chaisemartin.com>
In-Reply-To
<828c6333-0ba0-2a01-324e-f910a8042ca1@morey-chaisemartin.com>

Set curl as the runtime default when it is available. When linked against older curl versions (< 7_34_0) or without curl, use the legacy imap implementation.

The goal is to validate feature parity between the legacy and the curl implementation, deprecate the legacy implementation later on and in the long term, hopefully drop it altogether.

Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
---
 imap-send.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index 7e39993d95..af1e1576bd 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -35,11 +35,11 @@ typedef void *SSL;
 #include "http.h"
 #endif
 
-#if defined(USE_CURL_FOR_IMAP_SEND) && defined(NO_OPENSSL)
-/* only available option */
+#if defined(USE_CURL_FOR_IMAP_SEND)
+/* Always default to curl if it's available. */
 #define USE_CURL_DEFAULT 1
 #else
-/* strictly opt in */
+/* We don't have curl, so continue to use the historical implementation */
 #define USE_CURL_DEFAULT 0
 #endif
 
-- 
2.14.1.461.g503560879
Previous: Junio C HamanoNext: Nicolas Morey-Chaisemartin
Message 6 of 7 in “imap-send: Fix and enable curl by default”
  1. 0/4 imap-send: Fix and enable curl by defaultNicolas Morey-Chaisemartin, Sep 14, 2017
  2. 2/4 imap-send: add wrapper to get server credentials if neededNicolas Morey-Chaisemartin, Sep 14, 2017
  3. 3/4 imap_send: setup_curl: retreive credentials if not set in config fileNicolas Morey-Chaisemartin, Sep 14, 2017
  4. Junio C HamanoSep 15, 2017
  5. Junio C HamanoSep 15, 2017
  6. 4/4 imap-send: use curl by default when possibleNicolas Morey-Chaisemartin, Sep 14, 2017
  7. 1/4 imap-send: return with error if curl failedNicolas Morey-Chaisemartin, Sep 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.